Check if CometLogger experiment is alive #19915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EtayLivne
requested review from
williamFalcon,
awaelchli and
justusschock
as code owners
added 3 commits
June 17, 2024 15:23
awaelchli
changed the title
awaelchli
approved these changes
Jun 18, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19915 +/- ##
==========================================
- Coverage 84% 53% -31%
==========================================
Files 426 418 -8
Lines 35293 35140 -153
==========================================
- Hits 29628 18720 -10908
- Misses 5665 16420 +10755 |
awaelchli
pushed a commit
that referenced
this pull request
Jun 27, 2024
Co-authored-by: Etay Livne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A tiny patch to align how the CometLogger class checks if the the underlying Comet Experiment object it holds needs to be reactivated. Solves cases where CometClient suddenly stops being able to log (e.g due to another Experiment instance being created by any other source).
Fixes #19900
PR review
📚 Documentation preview 📚: https://pytorch-lightning--19915.org.readthedocs.build/en/19915/